[BACKPORT] Use version_compare to compare version strings correctly#18423
Closed
lewisvoncken wants to merge 1 commit intomagento:2.2-developfrom
Closed
[BACKPORT] Use version_compare to compare version strings correctly#18423lewisvoncken wants to merge 1 commit intomagento:2.2-developfrom
lewisvoncken wants to merge 1 commit intomagento:2.2-developfrom
Conversation
Contributor
|
Hi @lewisvoncken |
Contributor
|
Hi @lewisvoncken Could you please let us know if you are going to proceed with this PR. Thank you |
Contributor
|
Hi @lewisvoncken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of PR #18173
Version numbers were compared with regular alphanumeric string comparison
<, which results in1.10 < 1.9. Instead,version_compareshould be usedManual testing scenarios
Contribution checklist